Page MenuHomePhabricator
Differential D14598

Move Owners to EditEngine
ClosedPublic
Actions

Authored by epriestley on Nov 29 2015, 5:36 PM.
Tags
None
Referenced Files
F14762317: D14598.id35402.diff
Thu, Jan 23, 5:40 AM
Unknown Object (File)
Tue, Jan 21, 8:20 PM
Unknown Object (File)
Wed, Jan 15, 11:10 AM
Unknown Object (File)
Wed, Jan 15, 11:00 AM
Unknown Object (File)
Sun, Jan 12, 3:08 PM
Unknown Object (File)
Sat, Jan 11, 1:15 PM
Unknown Object (File)
Wed, Jan 8, 10:45 AM
Unknown Object (File)
Fri, Jan 3, 5:34 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9132: Build an ApplicationEditor abstraction
Commits
Restricted Diffusion Commit
rPa407b83dc276: Move Owners to EditEngine
Summary

Ref T9132. Paste is in fairly good shape so Owners is up next. Reasoning:

  • One install wants API access for it.
  • It's a simple application for getting CustomFields working with EditEngine.

This only does the EditEngine part, so CustomFields are no longer editable until I make that work. That will be up next, and I'll hold this until that's ready.

Test Plan
  • Created and edited packages via web UI.
  • Created and edited package editing forms via web UI.
  • Created and edited packages via Conduit.

Diff Detail

Repository
rP Phabricator
Branch
eengine21
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/owners/storage/PhabricatorOwnersPackage.php:286XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9120
Build 10754: Run Core Tests
Build 10753: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35309.Nov 29 2015, 5:36 PM
epriestley retitled this revision from to Move Owners to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9132: Build an ApplicationEditor abstraction.
chad accepted this revision.Nov 30 2015, 5:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 5:08 PM
epriestley updated this revision to Diff 35340.Nov 30 2015, 5:15 PM
epriestley edited edge metadata.
  • Just a cleanup rebase for the heck of it.
Closed by commit rPa407b83dc276: Move Owners to EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 2 2015, 1:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35309

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/httpparametertype/AphrontPHIDListHTTPParameterType.php

Loading...
View Options

src/applications/owners/application/PhabricatorOwnersApplication.php

Loading...
View Options

src/applications/owners/conduit/OwnersEditConduitAPIMethod.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersEditController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersListController.php

Loading...
View Options

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorDatasourceEditField.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...
Phabricator · Built by Phacility