Page MenuHomePhabricator

Move Owners to EditEngine
ClosedPublic

Authored by epriestley on Nov 29 2015, 5:36 PM.
Tags
None
Referenced Files
F18839299: D14598.diff
Mon, Oct 27, 3:30 PM
F18819408: D14598.id.diff
Oct 22 2025, 6:08 AM
F18807685: D14598.diff
Oct 19 2025, 2:58 AM
F18778360: D14598.id35309.diff
Oct 11 2025, 9:03 AM
F18778359: D14598.id35340.diff
Oct 11 2025, 9:03 AM
F18744998: D14598.id35340.diff
Oct 3 2025, 4:54 AM
F18738808: D14598.diff
Oct 1 2025, 5:20 PM
F18722938: D14598.id35309.diff
Sep 29 2025, 11:38 PM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9132: Build an ApplicationEditor abstraction
Commits
Restricted Diffusion Commit
rPa407b83dc276: Move Owners to EditEngine
Summary

Ref T9132. Paste is in fairly good shape so Owners is up next. Reasoning:

  • One install wants API access for it.
  • It's a simple application for getting CustomFields working with EditEngine.

This only does the EditEngine part, so CustomFields are no longer editable until I make that work. That will be up next, and I'll hold this until that's ready.

Test Plan
  • Created and edited packages via web UI.
  • Created and edited package editing forms via web UI.
  • Created and edited packages via Conduit.

Diff Detail

Repository
rP Phabricator
Branch
eengine21
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/owners/storage/PhabricatorOwnersPackage.php:286XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9120
Build 10754: Run Core Tests
Build 10753: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Move Owners to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 5:08 PM
epriestley edited edge metadata.
  • Just a cleanup rebase for the heck of it.
This revision was automatically updated to reflect the committed changes.