Differential D14597

Modernize Maniphest
ClosedPublic
Actions

Authored by chad on Nov 29 2015, 1:58 AM.

Tags

None

Referenced Files

	F17637836: D14597.id35325.diff
	Fri, Jul 11, 4:08 PM

	F17637832: D14597.id.diff
	Fri, Jul 11, 4:08 PM

	F17637830: D14597.diff
	Fri, Jul 11, 4:08 PM

	Unknown Object (File)
	Wed, Jul 2, 12:53 AM

	Unknown Object (File)
	Jun 20 2025, 9:12 AM

	Unknown Object (File)
	May 11 2025, 8:41 PM

	Unknown Object (File)
	May 10 2025, 7:54 PM

	Unknown Object (File)
	May 8 2025, 3:23 PM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rPb9fcaadce88b: Modernize Maniphest

Summary

Updates (some) of Maniphest for modern methods. Didn't convert Reports (probably need a setNavigation call added).

Test Plan

View List, edit task, new task, view reports.

Diff Detail

Repository

Branch

newpage-maniphest

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9118
Build 10751: Run Core Tests
Build 10750: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	57 ms	ManiphestTaskTestCase::Unknown Unit Message ("")
	10 ms	ManiphestTaskTestCase::Unknown Unit Message ("")
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("")
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 298 Passed)

Event Timeline

chad updated this revision to Diff 35307.Nov 29 2015, 1:58 AM

chad retitled this revision from to Modernize Maniphest.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 29 2015, 1:58 AM

epriestley accepted this revision.Nov 29 2015, 4:46 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 29 2015, 4:46 PM

Closed by commit rPb9fcaadce88b: Modernize Maniphest (authored by chad, committed by chad). · Explain WhyNov 30 2015, 2:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestController.php

12 lines

ManiphestTaskDetailController.php

30 lines

ManiphestTaskEditController.php

21 lines

Diff 35307

src/applications/maniphest/controller/ManiphestController.php

Loading...

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...