Page MenuHomePhabricator
Differential D14562

Add a linter rule for `abstract` methods within an `interface`
ClosedPublic
Actions

Authored by joshuaspence on Nov 23 2015, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 17, 5:06 AM
Unknown Object (File)
Tue, Jun 17, 5:02 AM
Unknown Object (File)
Mon, Jun 16, 4:58 AM
Unknown Object (File)
May 28 2025, 1:15 PM
Unknown Object (File)
May 7 2025, 8:47 AM
Unknown Object (File)
Apr 29 2025, 7:40 AM
Unknown Object (File)
Apr 24 2025, 12:53 AM
Unknown Object (File)
Apr 18 2025, 11:24 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCb323ad4d6484: Add a linter rule for `abstract` methods within an `interface`
Summary

interfaces cannot contain abstract methods. This construct will cause a PHP fatal error:

Access type for interface method SomeInterface::someMethod() must be omitted
Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35220.Nov 23 2015, 9:24 PM
joshuaspence retitled this revision from to Add a linter rule for `abstract` methods within an `interace`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 23 2015, 9:24 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 25 2015, 2:57 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 25 2015, 2:57 PM
epriestley retitled this revision from Add a linter rule for `abstract` methods within an `interace` to Add a linter rule for `abstract` methods within an `interface`.Nov 25 2015, 3:07 PM
epriestley edited edge metadata.
joshuaspence updated this object.Nov 25 2015, 8:22 PM
Closed by commit rARCb323ad4d6484: Add a linter rule for `abstract` methods within an `interface` (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 25 2015, 8:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35260

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistInterfaceAbstractMethodXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInterfaceAbstractMethodXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/interface-abstract-method/abstract.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/interface-abstract-method/no-abstract.lint-test

Loading...
Phabricator · Built by Phacility