Paths

Table of Contentst

Differential D14559

Add a linter rule to determine whether a class should be marked as `abstract`
ClosedPublic
Actions

Authored by joshuaspence on Nov 23 2015, 8:57 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC37571d883952: Add a linter rule to determine whether a class should be marked as `abstract`

Summary

A class containing abstract methods must itself be marked as abstract.

PHP Fatal error:  Class X contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (X::Y) in /home/josh/workspace/github.com/phacility/arcanist/test.php on line 5

Test Plan

Added unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35214.Nov 23 2015, 8:57 PM

joshuaspence retitled this revision from to Add a linter rule to determine whether a class should be marked as `abstract`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 23 2015, 8:57 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 23 2015, 8:57 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2015, 8:57 PM

joshuaspence updated this object.Nov 23 2015, 9:18 PM

joshuaspence edited edge metadata.

Closed by commit rARC37571d883952: Add a linter rule to determine whether a class should be marked as `abstract` (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 23 2015, 9:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

xhpast/

rules/

ArcanistClassMustBeDeclaredAbstractXHPASTLinterRule.php

74 lines

__tests__/

ArcanistClassMustBeDeclaredAbstractXHPASTLinterRuleTestCase.php

11 lines

class-must-be-declared-abstract/

is-abstract.lint-test

5 lines

is-not-abstract.lint-test

5 lines

should-be-abstract.lint-test

6 lines

Diff 35223

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/xhpast/rules/ArcanistClassMustBeDeclaredAbstractXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistClassMustBeDeclaredAbstractXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/class-must-be-declared-abstract/is-abstract.lint-test

View Options

src/lint/linter/xhpast/rules/tests/class-must-be-declared-abstract/is-not-abstract.lint-test

View Options

src/lint/linter/xhpast/rules/tests/class-must-be-declared-abstract/should-be-abstract.lint-test

Add a linter rule to determine whether a class should be marked as `abstract`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35223

src/__phutil_library_map__.php

src/lint/linter/xhpast/rules/ArcanistClassMustBeDeclaredAbstractXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistClassMustBeDeclaredAbstractXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/class-must-be-declared-abstract/is-abstract.lint-test

src/lint/linter/xhpast/rules/__tests__/class-must-be-declared-abstract/is-not-abstract.lint-test

src/lint/linter/xhpast/rules/__tests__/class-must-be-declared-abstract/should-be-abstract.lint-test

Add a linter rule to determine whether a class should be marked as `abstract`
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/xhpast/rules/tests/ArcanistClassMustBeDeclaredAbstractXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/class-must-be-declared-abstract/is-abstract.lint-test

src/lint/linter/xhpast/rules/tests/class-must-be-declared-abstract/is-not-abstract.lint-test

src/lint/linter/xhpast/rules/tests/class-must-be-declared-abstract/should-be-abstract.lint-test