Differential D14548

Maybe possibly really fix :last-child in phabricator-remarkup
ClosedPublic
Actions

Authored by chad on Nov 23 2015, 4:28 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9833: Remarkup comment areas have an excessively tall bottom margin

Commits

Restricted Diffusion Commit
rPd0e87fc11445: Maybe possibly really fix :last-child in phabricator-remarkup

Summary

This rule should correctly target the last direct descendent child of .phabricator-remarkup, and not grandchildren. Fixes T9833

Test Plan

Test commenting, documents, descriptions, and other remarkup areas. All spacing seems consistent.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35191.Nov 23 2015, 4:28 PM

chad retitled this revision from to Maybe possibly really fix :last-child in phabricator-remarkup.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9833: Remarkup comment areas have an excessively tall bottom margin.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 23 2015, 4:28 PM

epriestley accepted this revision.Nov 23 2015, 4:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2015, 4:33 PM

Closed by commit rPd0e87fc11445: Maybe possibly really fix :last-child in phabricator-remarkup (authored by chad, committed by chad). · Explain WhyNov 23 2015, 4:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

2 lines

Diff 35192

View Options

resources/celerity/map.php