Paths

Table of Contentst

Fix edits of Ponder comments which mention other objects
ClosedPublic
Actions

Authored by epriestley on Nov 22 2015, 10:15 PM.

Tags

None

Referenced Files

	F18148073: D14539.diff
	Thu, Aug 14, 4:33 PM

	F18148059: D14539.id35173.diff
	Thu, Aug 14, 4:32 PM

	F18081590: D14539.id35168.diff
	Tue, Aug 5, 12:55 AM

	F18053798: D14539.id35173.diff
	Mon, Aug 4, 5:30 AM

	F17924527: D14539.id35168.diff
	Wed, Jul 30, 10:05 AM

	F17869396: D14539.id.diff
	Mon, Jul 28, 11:13 AM

	F17852539: D14539.diff
	Sun, Jul 27, 12:45 PM

	Unknown Object (File)
	May 29 2025, 8:15 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T9806: Exception while editing Ponder comment to an answer

Commits

Restricted Diffusion Commit
rPd7212d855e10: Fix edits of Ponder comments which mention other objects

Summary

Fixes T9806. See some discussion there.

Test Plan

Edited a comment with T12 in it.
Before change: exception.
After change: no exception.

Diff Detail

Repository

rP Phabricator

Branch

cedgeedit

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8979
Build 10543: Run Core Tests
Build 10542: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35168.Nov 22 2015, 10:15 PM

epriestley retitled this revision from to Fix edits of Ponder comments which mention other objects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9806: Exception while editing Ponder comment to an answer.

chad accepted this revision.Nov 22 2015, 10:16 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 22 2015, 10:16 PM

Closed by commit rPd7212d855e10: Fix edits of Ponder comments which mention other objects (authored by epriestley, committed by epriestley). · Explain WhyNov 22 2015, 11:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

ponder/

editor/

PonderAnswerEditor.php

1 line

Diff 35168

View Options

src/applications/ponder/editor/PonderAnswerEditor.php

Fix edits of Ponder comments which mention other objectsClosedPublicActions