Fix edits of Ponder comments which mention other objects
ClosedPublic
Actions

Authored by epriestley on Nov 22 2015, 10:15 PM.

Details

Reviewers

chad

Maniphest Tasks

T9806: Exception while editing Ponder comment to an answer

Commits

Restricted Diffusion Commit
rPd7212d855e10: Fix edits of Ponder comments which mention other objects

Summary

Fixes T9806. See some discussion there.

Test Plan

Edited a comment with T12 in it.
Before change: exception.
After change: no exception.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35168.Nov 22 2015, 10:15 PM

epriestley retitled this revision from to Fix edits of Ponder comments which mention other objects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9806: Exception while editing Ponder comment to an answer.

chad accepted this revision.Nov 22 2015, 10:16 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 22 2015, 10:16 PM

Closed by commit rPd7212d855e10: Fix edits of Ponder comments which mention other objects (authored by epriestley, committed by epriestley). · Explain WhyNov 22 2015, 11:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

ponder/

editor/

PonderAnswerEditor.php

1 line

Diff 35173

View Options

src/applications/ponder/editor/PonderAnswerEditor.php

Fix edits of Ponder comments which mention other objectsClosedPublicActions