Don't give Mercurial empty string as a remote name
ClosedPublic
Actions

Authored by epriestley on Nov 21 2015, 5:34 PM.

Details

Reviewers

chad

Maniphest Tasks

T9807: `arc land` no longer works with upgraded Mercurial (3.6.1)

Commits

rARCb32149495b85: Don't give Mercurial empty string as a remote name

Summary

Fixes T9807. We currently run commands like this in some cases:

hg push -r master ''

From T9807, it seems that older Mercurial treated '' in the same way it would treat no argument, while newer Mercurial does not.

Passing '' is unusual and not intended.

Test Plan

From T9807, @cspeckmim confirmed that running this command without the '' works, and @jgelgens tested the patch itself.

I didn't actually run this code myself, since I don't have Mercurial 3.6.1 installed and the fix seems straightfoward.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35151.Nov 21 2015, 5:34 PM

epriestley retitled this revision from to Don't give Mercurial empty string as a remote name.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).

epriestley added a subscriber: cspeckmim.

chad accepted this revision.Nov 21 2015, 5:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 21 2015, 5:35 PM

Closed by commit rARCb32149495b85: Don't give Mercurial empty string as a remote name (authored by epriestley, committed by epriestley). · Explain WhyNov 21 2015, 5:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistLandWorkflow.php

14 lines

Diff 35152

View Options

src/workflow/ArcanistLandWorkflow.php

Don't give Mercurial empty string as a remote nameClosedPublicActions