Page MenuHomePhabricator
Differential D14513

Add a linter rule for nested namespaces
ClosedPublic
Actions

Authored by joshuaspence on Nov 18 2015, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 10:02 PM
Unknown Object (File)
Mon, Nov 18, 1:02 AM
Unknown Object (File)
Thu, Nov 14, 8:54 AM
Unknown Object (File)
Mon, Nov 11, 6:14 AM
Unknown Object (File)
Sun, Nov 10, 11:42 AM
Unknown Object (File)
Fri, Nov 8, 8:42 PM
Unknown Object (File)
Fri, Nov 8, 8:42 PM
Unknown Object (File)
Fri, Nov 8, 7:55 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC149e7895fbd5: Add a linter rule for nested namespaces
Summary

Namespace declarations cannot be nested, see https://3v4l.org/kRUNj.

Test Plan

Added unit tests

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35110.Nov 18 2015, 10:29 PM
joshuaspence retitled this revision from to Add a linter rule for nested namespaces.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 18 2015, 10:29 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 18 2015, 10:38 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2015, 10:38 PM
Closed by commit rARC149e7895fbd5: Add a linter rule for nested namespaces (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 19 2015, 8:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
lint/
linter/
xhpast/
rules/
29 lines
__tests__/
10 lines
nested-namespaces/
9 lines

Diff 35118

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistNestedNamespacesXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistNestedNamespacesXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/nested-namespaces/nested.lint-test

Loading...
Phabricator · Built by Phacility