Page MenuHomePhabricator

Ref T6049, Add Phurl URL create capability
ClosedPublic

Authored by lpriestley on Nov 18 2015, 8:40 PM.
Tags
None
Referenced Files
F18091754: D14510.id35146.diff
Thu, Aug 7, 12:33 AM
F18085331: D14510.id.diff
Tue, Aug 5, 7:09 PM
F17976149: D14510.id35146.diff
Fri, Aug 1, 5:16 PM
F17942207: D14510.id35101.diff
Thu, Jul 31, 6:27 AM
F17864402: D14510.id.diff
Mon, Jul 28, 2:06 AM
F17850158: D14510.id.diff
Sun, Jul 27, 9:35 AM
F17824620: D14510.diff
Sat, Jul 26, 5:35 AM
F17703338: D14510.id35101.diff
Wed, Jul 16, 1:15 AM
Subscribers

Details

Summary

Ref T6049, Add Phurl URL create capability

Test Plan
  • Change HomeApplicationsPhurlConfigure to allow no one to create Phurl URLs
  • Attempt PhurlShorten URL. Should not be able to create a Phurl.

Diff Detail

Repository
rP Phabricator
Branch
phurlcreatecapability
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8956
Build 10514: Run Core Tests
Build 10513: arc lint + arc unit

Event Timeline

lpriestley retitled this revision from to Ref T6049, Add Phurl URL create capability.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phurl/application/PhabricatorPhurlApplication.php
67

For consistency, just omit this caption. In other applications, "Default Policies" (like "Default View Policy" and "Default Edit Policy") are used to prefill "Can View" and "Can Edit" when creating new objects. This isn't a "Default" policy like those policies.

src/applications/phurl/capability/PhabricatorPhurlURLCreateCapability.php
7

For consistency, omit .default.

This revision is now accepted and ready to land.Nov 18 2015, 8:45 PM
lpriestley edited edge metadata.

Omitting stuff for consistency

This revision was automatically updated to reflect the committed changes.