Page MenuHomePhabricator
Differential D14508

Allow EditEngine forms to have defaults assigned
ClosedPublic
Actions

Authored by epriestley on Nov 18 2015, 6:40 PM.
Tags
None
Referenced Files
F14408230: D14508.diff
Tue, Dec 24, 4:17 AM
Unknown Object (File)
Mon, Dec 16, 10:22 AM
Unknown Object (File)
Sat, Dec 7, 6:18 PM
Unknown Object (File)
Mon, Dec 2, 11:21 PM
Unknown Object (File)
Mon, Dec 2, 11:20 PM
Unknown Object (File)
Wed, Nov 27, 12:05 AM
Unknown Object (File)
Nov 19 2024, 6:09 AM
Unknown Object (File)
Nov 12 2024, 8:57 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9132: Build an ApplicationEditor abstraction
Commits
Restricted Diffusion Commit
rP53d5cd395077: Allow EditEngine forms to have defaults assigned
Summary

Ref T9132. Allow form configurations to include defaults (like default projects, spaces, policies, etc).

Test Plan

Defaulted "Language" to "Rainbow", plus other adjustments:

Screen Shot 2015-11-18 at 10.37.46 AM.png (1×1 px, 155 KB)

Screen Shot 2015-11-18 at 10.37.50 AM.png (1×1 px, 156 KB)

Screen Shot 2015-11-18 at 10.37.48 AM.png (1×1 px, 149 KB)

Screen Shot 2015-11-18 at 10.37.59 AM.png (1×1 px, 218 KB)

Diff Detail

Repository
rP Phabricator
Branch
eengine17
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8906
Build 10432: Run Core Tests
Build 10431: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35096.Nov 18 2015, 6:40 PM
epriestley retitled this revision from to Allow EditEngine forms to have defaults assigned.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9132: Build an ApplicationEditor abstraction.
chad accepted this revision.Nov 19 2015, 5:53 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2015, 5:53 AM
Closed by commit rP53d5cd395077: Allow EditEngine forms to have defaults assigned (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2015, 12:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35096

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/transactions/application/PhabricatorTransactionsApplication.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorEditEngineConfigurationViewController.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php

Loading...
Phabricator · Built by Phacility