Differential D14502

Ref T6049, Phurl object view should always display some sort of header.
ClosedPublic
Actions

Authored by lpriestley on Nov 17 2015, 8:03 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6049: Implement Phurl, a URL shortener/bookmarking application

Commits

Restricted Diffusion Commit
rPa41b85788263: Ref T6049, Phurl object view should always display some sort of header.

Summary

Ref T6049, Phurl object view should display Phurl name or Phurl long url as header.

Test Plan

Create Phurl with no name. Header should show long url as header.
Add name to Phurl. Header should be new Phurl name.

Diff Detail

Repository

rP Phabricator

Branch

phurlviewheader

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8892
Build 10410: Run Core Tests
Build 10409: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 35082.Nov 17 2015, 8:03 PM

lpriestley retitled this revision from to Ref T6049, Phurl object view should always display some sort of header..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T6049: Implement Phurl, a URL shortener/bookmarking application.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 17 2015, 8:03 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 18 2015, 9:56 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 18 2015, 9:56 AM

Closed by commit rPa41b85788263: Ref T6049, Phurl object view should always display some sort of header. (authored by lpriestley, committed by lpriestley). · Explain WhyNov 18 2015, 7:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

controller/

PhabricatorPhurlURLViewController.php

2 lines

storage/

PhabricatorPhurlURL.php

2 lines

Diff 35082

View Options

src/applications/phurl/controller/PhabricatorPhurlURLViewController.php