Page MenuHomePhabricator
Differential D14497

Fix ArcanistCSSLintLinter issue for messages without line number
ClosedPublic
Actions

Authored by dereckson on Nov 17 2015, 5:31 AM.
Tags
None
Referenced Files
F15552014: D14497.id35076.diff
Sun, Apr 27, 7:16 PM
F15548979: D14497.diff
Sun, Apr 27, 3:07 AM
F15533978: D14497.id35076.diff
Wed, Apr 23, 10:43 PM
F15529464: D14497.diff
Tue, Apr 22, 8:05 PM
F15521562: D14497.id35076.diff
Sun, Apr 20, 3:18 PM
F15521561: D14497.id35070.diff
Sun, Apr 20, 3:18 PM
F15490686: D14497.id35070.diff
Fri, Apr 11, 7:42 PM
F15487900: D14497.id35076.diff
Thu, Apr 10, 5:54 PM
View All Files
Subscribers
Korvin

Details

Reviewers
joshuaspence
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9804: ArcanistCSSLintLinter: Parameter passed to "setLine()" must be an integer
Commits
rARCb25cf080bc55: Fix ArcanistCSSLintLinter issue for messages without line number
Summary

csslint offers some diagnostics related to all the document without any
relevant line number.

In such case, arc lint failed, as setLine expects null or an integer,
but not an empty string.

The 'char' and 'line' attributes in XML report are now optional.

Fixes T9804.

Test Plan

test case to repro the issue added

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 35070.Nov 17 2015, 5:31 AM
dereckson added a task: T9804: ArcanistCSSLintLinter: Parameter passed to "setLine()" must be an integer.
dereckson retitled this revision from to Fix ArcanistCSSLintLinter issue for messages without line number.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added reviewers: epriestley, joshuaspence.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptNov 17 2015, 5:31 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 17 2015, 3:13 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2015, 3:13 PM
Closed by commit rARCb25cf080bc55: Fix ArcanistCSSLintLinter issue for messages without line number (authored by dereckson, committed by epriestley). · Explain WhyNov 17 2015, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
23 lines
__tests__/
csslint/
9 lines

Diff 35076

View Options

src/lint/linter/ArcanistCSSLintLinter.php

Loading...
View Options

src/lint/linter/__tests__/csslint/no-line-related-issue.lint-test

Loading...
Phabricator · Built by Phacility