Page MenuHomePhabricator

Fix ArcanistCSSLintLinter issue for messages without line number
ClosedPublic

Authored by dereckson on Nov 17 2015, 5:31 AM.

Details

Summary

csslint offers some diagnostics related to all the document without any
relevant line number.

In such case, arc lint failed, as setLine expects null or an integer,
but not an empty string.

The 'char' and 'line' attributes in XML report are now optional.

Fixes T9804.

Test Plan

test case to repro the issue added

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson retitled this revision from to Fix ArcanistCSSLintLinter issue for messages without line number.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added reviewers: epriestley, joshuaspence.
dereckson updated this revision to Diff 35070.
epriestley edited edge metadata.Nov 17 2015, 3:13 PM
epriestley accepted this revision.
This revision is now accepted and ready to land.Nov 17 2015, 3:13 PM
This revision was automatically updated to reflect the committed changes.