Page MenuHomePhabricator

Fix ArcanistCSSLintLinter issue for messages without line number
ClosedPublic

Authored by dereckson on Nov 17 2015, 5:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 6:22 PM
Unknown Object (File)
Tue, Dec 10, 6:25 PM
Unknown Object (File)
Mon, Dec 9, 5:20 PM
Unknown Object (File)
Sun, Dec 8, 4:54 PM
Unknown Object (File)
Fri, Dec 6, 12:35 AM
Unknown Object (File)
Thu, Dec 5, 7:31 AM
Unknown Object (File)
Sat, Nov 30, 10:20 PM
Unknown Object (File)
Fri, Nov 29, 11:05 AM
Subscribers

Details

Summary

csslint offers some diagnostics related to all the document without any
relevant line number.

In such case, arc lint failed, as setLine expects null or an integer,
but not an empty string.

The 'char' and 'line' attributes in XML report are now optional.

Fixes T9804.

Test Plan

test case to repro the issue added

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to Fix ArcanistCSSLintLinter issue for messages without line number.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added reviewers: epriestley, joshuaspence.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2015, 3:13 PM
This revision was automatically updated to reflect the committed changes.