Page MenuHomePhabricator

Have EditEngine API methods provide the correct application to Conduit
ClosedPublic

Authored by epriestley on Nov 16 2015, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 11:49 PM
Unknown Object (File)
Sat, Feb 8, 11:49 PM
Unknown Object (File)
Sat, Feb 8, 11:49 PM
Unknown Object (File)
Sat, Feb 8, 11:49 PM
Unknown Object (File)
Jan 31 2025, 8:06 AM
Unknown Object (File)
Jan 24 2025, 9:59 AM
Unknown Object (File)
Jan 24 2025, 9:59 AM
Unknown Object (File)
Jan 24 2025, 9:59 AM
Subscribers

Details

Summary

Fixes T9799. Currently, if you can't see an application like Paste, we fatal when trying to generate a result for conduit.query, because the new EditEngine-based paste.edit method doesn't "know" that it's a "Paste" method.

Straighten this out, and use policies and queries a little more correctly/consistently.

Test Plan
  • Called conduit.query as a user who does not have permission to use Paste.
  • Before change: fatal.
  • After change: results, excluding "paste.*" methods.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Have EditEngine API methods provide the correct application to Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2015, 5:49 PM
This revision was automatically updated to reflect the committed changes.