Ref T6049, remarkup links to use short URLs and make commenting on Phurl's actually work
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T6049: Implement Phurl, a URL shortener/bookmarking application
- Commits
- Restricted Diffusion Commit
rP59c5cd95e7c9: Remarkup links to link to short url instead of long and fix commenting on…
- Create Phurl U123
- Comment on that Phurl ((123))
Comment should link to /u/123
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phurllinkredirect
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8889 Build 10405: Run Core Tests Build 10404: arc lint + arc unit
Event Timeline
| src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php | ||
|---|---|---|
| 10 | (Possibly we should make ((U123)) and ((123)) equivalent at some point, or maybe even require the U... form.) | |
| 51–52 | I think these should probably become methods on PhurlURL, like getDisplayName() and getRedirectURI() or similar: specifically, I think they'll have more callsites. The $redirect logic should also probably be like this? if (strlen($phurl->getAlias())) {
return '/u/alias';
} else {
return '/u/id';
} | |