Differential D14462

generalise XHPAST linting
AbandonedPublic
Actions

Authored by • Lswith on Nov 11 2015, 1:18 AM.

Tags

None

Referenced Files

	F19858024: D14462.id.diff
	Mar 14 2026, 12:51 AM

	F19854523: D14462.diff
	Mar 13 2026, 9:45 AM

	F18900320: D14462.id.diff
	Nov 7 2025, 8:42 PM

	F18881512: D14462.diff
	Nov 6 2025, 9:32 PM

	F18753881: D14462.id.diff
	Oct 4 2025, 8:37 PM

	F18748410: D14462.diff
	Oct 3 2025, 9:33 PM

	F18091321: D14462.id.diff
	Aug 6 2025, 9:03 PM

	F18088963: D14462.id34977.diff
	Aug 6 2025, 10:09 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

The Arcanist XHPAST linter is generalised for easier extensability.

Test Plan

run the arc unit tests as per usual. If they pass then the refactoring worked.

Diff Detail

Repository

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/land/ArcanistLandEngine.php:135	PHL1	Unknown Symbol
Error	src/land/ArcanistLandEngine.php:139	PHL1	Unknown Symbol
Error	src/upload/ArcanistFileUploader.php:249	PHL1	Unknown Symbol
Error	src/workflow/ArcanistCommitWorkflow.php:228	PHL1	Unknown Symbol
Error	src/workflow/ArcanistCoverWorkflow.php:123	PHL1	Unknown Symbol
Error	src/workflow/ArcanistDiffWorkflow.php:965	PHL1	Unknown Symbol
Error	src/workflow/ArcanistUpgradeWorkflow.php:65	PHL1	Unknown Symbol
Error	src/workflow/ArcanistUpgradeWorkflow.php:69	PHL1	Unknown Symbol
Error	src/workflow/ArcanistUploadWorkflow.php:147	PHL1	Unknown Symbol
Error	src/workflow/ArcanistWorkflow.php:902	PHL1	Unknown Symbol
Error	src/workflow/ArcanistWorkflow.php:906	PHL1	Unknown Symbol
Error	src/workflow/ArcanistWorkflow.php:941	PHL1	Unknown Symbol

Unit

Tests Passed

Build Status

Buildable 8787
Build 10236: arc lint + arc unit

Event Timeline

• Lswith updated this revision to Diff 34977.Nov 11 2015, 1:18 AM

• Lswith retitled this revision from to generalise XHPAST linting.

• Lswith updated this object.

• Lswith edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 11 2015, 1:18 AM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

joshuaspence added a reviewer: joshuaspence.Nov 11 2015, 1:35 AM

dat test plan tho

• Lswith edited the test plan for this revision. (Show Details)Nov 11 2015, 2:08 AM

• Lswith edited edge metadata.

I had a chat with @joshspence and this seems useless now because there is a better way.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

8 lines

lint/

linter/

ArcanistXHPASTLinter.php

100 lines

	ArcanistXHPASTLinterWithRules.php
	ArcanistXHPASTLinter.php

20 lines

xhpast/

	ArcanistBaseXHPASTLinterRule.php
	ArcanistXHPASTLinterRule.php

68 lines

ArcanistXHPASTLinterRule.php

165 lines

Diff 34977

src/__phutil_library_map__.php

Loading...

src/lint/linter/ArcanistXHPASTLinter.php

Loading...

src/lint/linter/ArcanistXHPASTLinterWithRules.php

Loading...

src/lint/linter/xhpast/ArcanistBaseXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

Loading...