Page MenuHomePhabricator

Fix a potentially lax hash comparison
ClosedPublic

Authored by epriestley on Nov 10 2015, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 3:08 AM
Unknown Object (File)
Fri, Mar 15, 7:00 AM
Unknown Object (File)
Tue, Mar 5, 2:22 AM
Unknown Object (File)
Tue, Mar 5, 2:22 AM
Unknown Object (File)
Tue, Mar 5, 2:22 AM
Unknown Object (File)
Feb 27 2024, 9:26 AM
Unknown Object (File)
Feb 11 2024, 7:22 PM
Unknown Object (File)
Feb 11 2024, 6:04 PM
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPb3d3130b718d: Fix a potentially lax hash comparison
Summary

Via HackerOne. See D14025. I missed this comparison when making the original change.

Test Plan
  • Used cat mail.txt | scripts/mail/mail_handler.php --process-duplicates to pipe mail in a whole lot of times.
  • Tried bad hashes, saw rejections.
  • Tried good hash, saw mail accepted.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a potentially lax hash comparison.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2015, 6:19 PM
This revision was automatically updated to reflect the committed changes.