Page MenuHomePhabricator

Fix PropertyList background color in PHUIDocumentView
ClosedPublic

Authored by chad on Nov 8 2015, 2:25 AM.
Tags
None
Referenced Files
F13223184: D14439.diff
Sun, May 19, 4:22 AM
F13216115: D14439.diff
Fri, May 17, 10:24 PM
F13211900: D14439.id34895.diff
Fri, May 17, 6:12 AM
F13207949: D14439.diff
Thu, May 16, 6:27 AM
F13179424: D14439.diff
Wed, May 8, 9:11 PM
Unknown Object (File)
Sat, May 4, 6:44 PM
Unknown Object (File)
Wed, May 1, 12:05 AM
Unknown Object (File)
Apr 17 2024, 2:51 PM

Details

Summary

Overzealous nuking.

Test Plan

Test Phriction, Phame, Diviner. All show property lists correctly.

Diff Detail

Repository
rP Phabricator
Branch
document-prop
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8695
Build 10090: Run Core Tests
Build 10089: arc lint + arc unit

Event Timeline

chad retitled this revision from to Fix PropertyList background color in PHUIDocumentView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2015, 2:14 PM
This revision was automatically updated to reflect the committed changes.

might want to cherry pick this. looks terrible without.

I cherry-picked it to stable and deployed it here and in the cluster.