Fixes T5371. By default now any draft is visible and editable by any member of a Blog. However I'm finding "Joinable by" to be an odd Policy by name, maybe make a custom "Can Post" capability instead?
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T5371: Allow other people to view and edit unpublished Phame blogs
Set blog joinable to admins only, see that notchad can't post. Set it to all users, notchad can post and edit.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phame-join-policy
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8692 Build 10083: Run Core Tests Build 10082: arc lint + arc unit
Event Timeline
Comment Actions
I think we could also consider letting anyone who can see the blog see the draft -- that is, make "draft" mean "don't publish/notify/show in the main list", not "this is secret". This is similar to planned "draft" behavior in Differential. Drafts are (or will be) visible in the transaction history after things publish anyway, I think, so they're never really going to be secret?
Do we even need a separate JOIN policy? Could we just use EDIT? In what reasonable case is it OK for a user to write blog posts but not update the blog description or whatever?
Comment Actions
(We can specialize the capability name, but either of those product changes might simplify things and moot the issue.)
Comment Actions
I'm for removing it for simplicity. I almost did last night, but this path also seemed pretty easy.