Differential D14436

Added support for severity.rules and severity for JSCS
Needs ReviewPublic
Actions

Authored by • mc0 on Nov 7 2015, 11:11 PM.

Details

Reviewers

joshuaspence

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9626: Fix JSCS's severity/severity.rules support

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

JSCS now supports filtering by error, warning or advice

Test Plan

JSCS unit test

Diff Detail

Repository

rARC Arcanist

Branch

T9630

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8690
Build 10080: arc lint + arc unit

Event Timeline

• mc0 updated this revision to Diff 34881.Nov 7 2015, 11:11 PM

• mc0 added a task: T9630: Support submodules in Drydock working copies.

• mc0 retitled this revision from to Added support for severity.rules and severity for JSCS.

• mc0 updated this object.

• mc0 edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 7 2015, 11:11 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

• mc0 edited tasks, added T9626: Fix JSCS's severity/severity.rules support; removed T9630: Support submodules in Drydock working copies.Nov 7 2015, 11:12 PM

joshuaspence added a reviewer: joshuaspence.Nov 13 2015, 7:32 AM

DheerendraRathor added a subscriber: DheerendraRathor.Nov 17 2015, 8:39 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistJscsLinter.php

49 lines

__tests__/

jscs/

curly-brace.lint-test

9 lines

Diff 34881

View Options

src/lint/linter/ArcanistJscsLinter.php

View Options

src/lint/linter/tests/jscs/curly-brace.lint-test

Added support for severity.rules and severity for JSCSNeeds ReviewPublicActions