Differential D14398

Slightly improve organization of PhabricatorApplicationEditEngine
ClosedPublic
Actions

Authored by epriestley on Nov 4 2015, 12:32 AM.

Details

Reviewers

chad

Maniphest Tasks

T9132: Build an ApplicationEditor abstraction

Commits

Restricted Diffusion Commit
rP9de4bc6f3acf: Slightly improve organization of PhabricatorApplicationEditEngine

Summary

Ref T9132. This just moves code around, breaks it up into some smaller chunks, tries to reduce duplication, and adds a touch of documentation.

Test Plan

Created and edited pastes.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34784.Nov 4 2015, 12:32 AM

epriestley retitled this revision from to Slightly improve organization of PhabricatorApplicationEditEngine.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9132: Build an ApplicationEditor abstraction.

chad accepted this revision.Nov 4 2015, 12:35 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2015, 12:35 AM

Closed by commit rP9de4bc6f3acf: Slightly improve organization of PhabricatorApplicationEditEngine (authored by epriestley, committed by epriestley). · Explain WhyNov 4 2015, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorApplicationEditEngine.php

436 lines

Diff 34803

View Options

src/applications/transactions/editengine/PhabricatorApplicationEditEngine.php

Slightly improve organization of PhabricatorApplicationEditEngineClosedPublicActions