Page MenuHomePhabricator

Roughly generate transaction-oriented API methods from EditEngines
ClosedPublic

Authored by epriestley on Nov 3 2015, 6:03 PM.

Details

Summary

Ref T5873. Ref T9132. This is really rough and feels pretty flimsy at the edges (missing validation, generality, modularity, clean error handling, etc) but gets us most of the way toward generating plausible "whatever.edit" Conduit API methods from EditEngines.

These methods are full-power methods which can do everything the edit form can, automatically support the same range of operations, and update when new fields are added.

Test Plan
  • Used new paste.edit to create a new Paste.
  • Used new paste.edit to update an existing paste.
  • Applied a variety of different transactions.
  • Hit a reasonable set of errors.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 34769.Nov 3 2015, 6:03 PM
epriestley retitled this revision from to Roughly generate transaction-oriented API methods from EditEngines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Nov 3 2015, 6:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 3 2015, 6:10 PM
This revision was automatically updated to reflect the committed changes.