Page MenuHomePhabricator

Roughly generate transaction-oriented API methods from EditEngines
ClosedPublic

Authored by epriestley on Nov 3 2015, 6:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 6:04 PM
Unknown Object (File)
Thu, Mar 14, 5:41 PM
Unknown Object (File)
Thu, Mar 14, 5:23 PM
Unknown Object (File)
Thu, Mar 14, 5:15 PM
Unknown Object (File)
Wed, Mar 13, 5:45 PM
Unknown Object (File)
Wed, Mar 13, 4:59 PM
Unknown Object (File)
Mon, Mar 11, 4:57 PM
Unknown Object (File)
Thu, Mar 7, 4:52 PM
Subscribers
None

Details

Summary

Ref T5873. Ref T9132. This is really rough and feels pretty flimsy at the edges (missing validation, generality, modularity, clean error handling, etc) but gets us most of the way toward generating plausible "whatever.edit" Conduit API methods from EditEngines.

These methods are full-power methods which can do everything the edit form can, automatically support the same range of operations, and update when new fields are added.

Test Plan
  • Used new paste.edit to create a new Paste.
  • Used new paste.edit to update an existing paste.
  • Applied a variety of different transactions.
  • Hit a reasonable set of errors.

Screen Shot 2015-11-03 at 10.01.00 AM.png (1×1 px, 225 KB)

Screen Shot 2015-11-03 at 10.01.11 AM.png (1×1 px, 229 KB)

Screen Shot 2015-11-03 at 10.01.03 AM.png (1×1 px, 227 KB)

Screen Shot 2015-11-03 at 10.01.07 AM.png (1×1 px, 205 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Roughly generate transaction-oriented API methods from EditEngines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 3 2015, 6:10 PM
This revision was automatically updated to reflect the committed changes.