Differential D14389

Validate new Phurl URL
ClosedPublic
Actions

Authored by lpriestley on Nov 2 2015, 9:50 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9691: Creating a Phurl URL for a URL with an invalid protocol should throw an error

Commits

Restricted Diffusion Commit
rP60cf71e724c4: Validate new Phurl URL

Summary

Closes T9691, Validate URL on Phurl objects for using valid protocols.

Test Plan

Create or edit URL. Change URL to "asdf" and observe error. Change back to "http://google.com" and observe no error.

Diff Detail

Repository

rP Phabricator

Branch

phurlvalidateurl

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8568
Build 9894: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 34758.Nov 2 2015, 9:50 PM

lpriestley retitled this revision from to Validate new Phurl URL.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T9691: Creating a Phurl URL for a URL with an invalid protocol should throw an error.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 2 2015, 9:50 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 2 2015, 9:51 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 2 2015, 9:51 PM

Closed by commit rP60cf71e724c4: Validate new Phurl URL (authored by lpriestley, committed by lpriestley). · Explain WhyNov 2 2015, 9:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

editor/

PhabricatorPhurlURLEditor.php

15 lines

Diff 34758

View Options

src/applications/phurl/editor/PhabricatorPhurlURLEditor.php

Validate new Phurl URLClosedPublicActions