Page MenuHomePhabricator

Add styling for new Remarkup highlighter
ClosedPublic

Authored by chad on Nov 2 2015, 8:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 4:03 AM
Unknown Object (File)
Tue, Mar 5, 4:03 AM
Unknown Object (File)
Feb 14 2024, 7:48 PM
Unknown Object (File)
Feb 7 2024, 5:03 AM
Unknown Object (File)
Feb 7 2024, 5:03 AM
Unknown Object (File)
Feb 7 2024, 5:03 AM
Unknown Object (File)
Feb 7 2024, 4:48 AM
Unknown Object (File)
Jan 25 2024, 11:28 AM
Subscribers

Details

Summary

Adds some basic style to new Remarkup Highlighter Ref T5560

Test Plan

Wait for next diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add styling for new Remarkup highlighter.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Maybe update the documentation too, unless you want to do the !!!/etc versions first.

This revision is now accepted and ready to land.Nov 2 2015, 9:17 PM
This revision was automatically updated to reflect the committed changes.

If this is wrong place for this I apologize in advanced, but it would be really nice to be able to specify a highlight color.

Is there a specific color you'd like? We wanted to keep the syntax here light and easy.

I was thinking a light red, yellow and green. It looks like I could just modify the css to switch to a different color in general, but having multiple options would take away from the simplicity of the syntax.

We had originally planned !! violet !!, !!! green !!!, !!!! red !!!!, but decided to keep it simple and wait to see actually use cases.

I was thinking of it as instead of one option to just make something stand out, I'd use the colors to help signify how critical the highlighted text was.

This is a reasonable feature request to file.