Add styling for new Remarkup highlighter
ClosedPublic
Actions

Authored by chad on Nov 2 2015, 8:38 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5560: Add some sort of highlighting syntax to Remarkup

Commits

Restricted Diffusion Commit
rP8bbcd896b806: Add styling for new Remarkup highlighter

Summary

Adds some basic style to new Remarkup Highlighter Ref T5560

Test Plan

Wait for next diff.

Diff Detail

Repository

rP Phabricator

Branch

highlight

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8556
Build 9877: Run Core Tests
Build 9876: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	14 ms	ConpherenceRoomTestCase::Unknown Unit Message ("")
	25 ms	ConpherenceRoomTestCase::Unknown Unit Message ("")
	27 ms	ConpherenceRoomTestCase::Unknown Unit Message ("")
	15 ms	ConpherenceRoomTestCase::Unknown Unit Message ("")
	28 ms	ConpherenceRoomTestCase::Unknown Unit Message ("")
		View Full Test Results (19 Failed · 278 Passed)

Event Timeline

chad updated this revision to Diff 34746.Nov 2 2015, 8:38 PM

chad retitled this revision from to Add styling for new Remarkup highlighter.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T5560: Add some sort of highlighting syntax to Remarkup.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 2 2015, 8:38 PM

Maybe update the documentation too, unless you want to do the !!!/etc versions first.

This revision is now accepted and ready to land.Nov 2 2015, 9:17 PM

I'll follow up, yarp.

Closed by commit rP8bbcd896b806: Add styling for new Remarkup highlighter (authored by chad, committed by chad). · Explain WhyNov 2 2015, 9:20 PM

This revision was automatically updated to reflect the committed changes.

If this is wrong place for this I apologize in advanced, but it would be really nice to be able to specify a highlight color.

Is there a specific color you'd like? We wanted to keep the syntax here light and easy.

I was thinking a light red, yellow and green. It looks like I could just modify the css to switch to a different color in general, but having multiple options would take away from the simplicity of the syntax.

We had originally planned !! violet !!, !!! green !!!, !!!! red !!!!, but decided to keep it simple and wait to see actually use cases.

I was thinking of it as instead of one option to just make something stand out, I'd use the colors to help signify how critical the highlighted text was.