Page MenuHomePhabricator
Differential D14377

Redesign Legalpad
ClosedPublic
Actions

Authored by chad on Nov 1 2015, 9:37 PM.
Tags
None
Referenced Files
F13151430: D14377.diff
Sat, May 4, 6:33 PM
Unknown Object (File)
Sat, Apr 27, 12:21 AM
Unknown Object (File)
Thu, Apr 25, 10:57 PM
Unknown Object (File)
Thu, Apr 25, 10:57 PM
Unknown Object (File)
Wed, Apr 24, 11:49 PM
Unknown Object (File)
Wed, Apr 17, 11:41 PM
Unknown Object (File)
Thu, Apr 11, 8:02 AM
Unknown Object (File)
Apr 4 2024, 3:32 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPb7a4d3b9a51c: Redesign Legalpad
Summary

Rolls out PHUIDocumentViewPro to Legalpad. Minor tweaks to provide space around Preamble and Signature blocks. Otherwise, straight forward.

Test Plan

Build a new document with and without Preamble, sign document.

pasted_file (2×2 px, 851 KB)

Diff Detail

Repository
rP Phabricator
Branch
legalpad-pro
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8521
Build 9829: Run Core Tests
Build 9828: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34709.Nov 1 2015, 9:37 PM
chad retitled this revision from to Redesign Legalpad.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 1 2015, 9:37 PM
chad edited the test plan for this revision. (Show Details)Nov 1 2015, 9:38 PM
chad updated this revision to Diff 34710.Nov 1 2015, 11:59 PM
  • Clean up unused CSS
epriestley accepted this revision.Nov 2 2015, 12:01 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 2 2015, 12:01 AM
Closed by commit rPb7a4d3b9a51c: Redesign Legalpad (authored by chad, committed by chad). · Explain WhyNov 2 2015, 12:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
src/
applications/
legalpad/
controller/
27 lines
webroot/
rsrc/
css/
phui/
3 lines
13 lines
4 lines

Diff 34710

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document.css

Loading...
View Options

webroot/rsrc/css/phui/phui-info-view.css

Loading...
Phabricator · Built by Phacility