Paths

Table of Contentst

Differential D14375

Fix a translation
ClosedPublic
Actions

Authored by joshuaspence on Nov 1 2015, 8:34 PM.

Tags

None

Referenced Files

	F14057843: D14375.diff
	Sun, Nov 17, 7:18 AM

	F14039703: D14375.id34745.diff
	Mon, Nov 11, 6:13 AM

	F14039701: D14375.id.diff
	Mon, Nov 11, 6:13 AM

	F14026501: D14375.id34840.diff
	Fri, Nov 8, 1:22 AM

	F14026500: D14375.id34817.diff
	Fri, Nov 8, 1:22 AM

	F14026499: D14375.id34707.diff
	Fri, Nov 8, 1:22 AM

	F14026497: D14375.diff
	Fri, Nov 8, 1:22 AM

	F14018519: D14375.id34707.diff
	Tue, Nov 5, 2:03 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9655: Incorrect translation for differential revisions

Commits

Restricted Diffusion Commit
rPaf7b16248e19: Fix a translation

Summary

Fixes T9655.

Test Plan

I haven't tested this... it seems simple enough.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 34707.Nov 1 2015, 8:34 PM

joshuaspence retitled this revision from to Fix a translation.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T9655: Incorrect translation for differential revisions.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 1 2015, 8:34 PM

Herald added a subscriber: Korvin. · View Herald Transcript

That test failure is legitimately caused by your local 665a0ea.

This revision now requires changes to proceed.Nov 2 2015, 12:01 AM

Rebase

epriestley requested changes to this revision.Nov 2 2015, 8:37 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
818–823	This is really the problem -- missing an extra `array()` since the first `%s` is not variant.

This revision now requires changes to proceed.Nov 2 2015, 8:37 PM

joshuaspence added inline comments.Nov 2 2015, 8:38 PM

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
818–823	What do you mean "the problem"? The unit tests are passing now?

You observed an incorrect translation in email subject lines, and fixed an incorrect translation in Doorkeeper (task names in Jira/Asana). This change won't affect email and won't fix T9655. The translation on line 818 is the one to fix to fix email.

Derp

epriestley accepted this revision.Nov 5 2015, 2:48 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 5 2015, 2:48 PM

Closed by commit rPaf7b16248e19: Fix a translation (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 6 2015, 2:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

6 lines

Diff 34840

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...