Redesign Diviner
ClosedPublic
Actions

Authored by chad on Oct 31 2015, 7:34 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPc45ba3041682: Redesign Diviner

Summary

This implements PHUIDocumentViewPro which should move to be the base for all documents (Phame, Phriction, Legalpad, Diviner). Overall this feels really good to me, but I'd like to roll it out into Diviner specifically first to work through the issues and then move into other apps and drop PHUIDocumentView once everything is converted. Some features are:

White Background, no border on page
Table of Contents is move to hidden menu (more space for documentation)
Property List sits under the document

Some design decisions above are in anticipation of Phriction v3 and Unbeta Phame, specifically commenting and maybe some cool new Remarkup text layout options for Phame.

Test Plan

Went through tons of pages on Diviner on Desktop, Tablet, Mobile. Bounce back to Phriction to make sure DocumentView CSS changes actually look better there.

Screen Shot 2015-10-31 at 12.36.52 PM.png (2×2 px, 414 KB)

Screen Shot 2015-10-31 at 12.36.46 PM.png (2×2 px, 788 KB)

Screen Shot 2015-10-31 at 12.37.01 PM.png (2×2 px, 696 KB)

Screen Shot 2015-10-31 at 12.36.40 PM.png (2×2 px, 739 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34704.Oct 31 2015, 7:34 PM

chad retitled this revision from to Redesign Diviner.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 31 2015, 7:34 PM

chad edited the test plan for this revision. (Show Details)Oct 31 2015, 7:37 PM

joshuaspence added a subscriber: joshuaspence.Nov 1 2015, 1:01 AM

tycho.tatitscheff added a subscriber: tycho.tatitscheff.Nov 1 2015, 1:08 AM

Feels a touch light at first glance and the left-aligned actions seem a little weird/inconsistent, but let's see how it feels in practice.

I think moving the property list to the bottom is probably quite bad for some properties (particularly, the file where non-article atoms are defined is one of the most important pieces of information on the page, for me). This makes sense for a lot of the information though (like subscribers on a Phriction page) so maybe we can start here and figure out what's important enough to bring back up.

This revision is now accepted and ready to land.Nov 1 2015, 4:24 PM

I also think left-aligned action is kinda weird (phriction does align it right).

Else a big