Page MenuHomePhabricator
Differential D14360

Pull git upstream-path logic into a separate class
ClosedPublic
Actions

Authored by epriestley on Oct 28 2015, 6:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 11:37 PM
Unknown Object (File)
Tue, Feb 4, 10:25 PM
Unknown Object (File)
Tue, Jan 28, 9:28 AM
Unknown Object (File)
Fri, Jan 24, 7:39 PM
Unknown Object (File)
Fri, Jan 24, 9:33 AM
Unknown Object (File)
Dec 14 2024, 5:10 PM
Unknown Object (File)
Dec 8 2024, 8:56 PM
Unknown Object (File)
Dec 8 2024, 3:57 PM
View All Files
Subscribers
edibiase

Details

Reviewers
chad
Maniphest Tasks
T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking
Commits
rARC2a2fd6e338b7: Pull git upstream-path logic into a separate class
Summary

Ref T9661. I need to reuse this to fix the complex workflow described in T9661 where we need to follow multiple paths to the upstream and cascade updates across them.

Pull the logic into a separate class to make this easier and less copy/pastey.

This shouldn't change any behavior.

Test Plan

Ran arc land --preview from detached head, remote-tracking branch, non-tracking branch, local-tracking branch. Selection of target/remote seemed correct in all cases.

Diff Detail

Repository
rARC Arcanist
Branch
land4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8477
Build 9763: Run Core Tests
Build 9762: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34670.Oct 28 2015, 6:38 PM
epriestley retitled this revision from to Pull git upstream-path logic into a separate class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.
chad accepted this revision.Oct 28 2015, 6:46 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 28 2015, 6:46 PM
edibiase added a subscriber: edibiase.Oct 28 2015, 8:17 PM
Closed by commit rARC2a2fd6e338b7: Pull git upstream-path logic into a separate class (authored by epriestley, committed by epriestley). · Explain WhyOct 28 2015, 8:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
repository/
api/
28 lines
82 lines
workflow/
44 lines

Diff 34670

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/repository/api/ArcanistGitUpstreamPath.php

Loading...
View Options

src/workflow/ArcanistLandWorkflow.php

Loading...
Phabricator · Built by Phacility