Page MenuHomePhabricator
Differential D14350

Make "Land Revision" button state consistent, prevent non-accepted lands
ClosedPublic
Actions

Authored by epriestley on Oct 27 2015, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:51 PM
Unknown Object (File)
Fri, Apr 19, 7:45 PM
Unknown Object (File)
Fri, Apr 19, 3:50 PM
Unknown Object (File)
Mon, Apr 15, 9:25 AM
Unknown Object (File)
Sun, Apr 7, 11:13 PM
Unknown Object (File)
Mon, Apr 1, 8:41 AM
Unknown Object (File)
Mar 5 2024, 6:59 PM
Unknown Object (File)
Mar 5 2024, 6:59 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T182: Commit into repository directly from differential
Commits
Restricted Diffusion Commit
rP1c7443f8f242: Make "Land Revision" button state consistent, prevent non-accepted lands
Summary

Ref T182. Make the disabled state of the button more accurately reflect whether clicking it will work.

Don't allow "land" to proceed unless the revision is accepted.

Test Plan

Saw button in disabled state, clicked it, got "only accepted revisions" message.

Diff Detail

Repository
rP Phabricator
Branch
ldocs2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/drydock/operation/DrydockLandRepositoryOperation.php:218XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 8449
Build 9718: Run Core Tests
Build 9717: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34638.Oct 27 2015, 5:25 PM
epriestley retitled this revision from to Make "Land Revision" button state consistent, prevent non-accepted lands.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T182: Commit into repository directly from differential.
chad accepted this revision.Oct 27 2015, 6:47 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 27 2015, 6:47 PM
chad added a comment.Oct 27 2015, 6:48 PM

Tried to irresponsibly land this and failed.

epriestley added a comment.Oct 27 2015, 6:49 PM

That conflict is semi-legit with the current strategy, lemme update and then you can try again.

epriestley updated this revision to Diff 34641.Oct 27 2015, 6:50 PM
epriestley edited edge metadata.
  • Rebase.
Closed by commit rP1c7443f8f242: Make "Land Revision" button state consistent, prevent non-accepted lands (authored by epriestley, committed by chad). · Explain WhyOct 27 2015, 6:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
100 lines
landing/
20 lines
drydock/
operation/
97 lines

Diff 34641

View Options

src/applications/differential/controller/DifferentialRevisionOperationController.php

Loading...
View Options

src/applications/differential/landing/DifferentialLandingActionMenuEventListener.php

Loading...
View Options

src/applications/drydock/operation/DrydockLandRepositoryOperation.php

Loading...
Phabricator · Built by Phacility