Page MenuHomePhabricator

Make "Land Revision" button state consistent, prevent non-accepted lands
ClosedPublic

Authored by epriestley on Oct 27 2015, 5:25 PM.

Details

Summary

Ref T182. Make the disabled state of the button more accurately reflect whether clicking it will work.

Don't allow "land" to proceed unless the revision is accepted.

Test Plan

Saw button in disabled state, clicked it, got "only accepted revisions" message.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 34638.Oct 27 2015, 5:25 PM
epriestley retitled this revision from to Make "Land Revision" button state consistent, prevent non-accepted lands.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Oct 27 2015, 6:47 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 27 2015, 6:47 PM
chad added a comment.Oct 27 2015, 6:48 PM

Tried to irresponsibly land this and failed.

That conflict is semi-legit with the current strategy, lemme update and then you can try again.

epriestley updated this revision to Diff 34641.Oct 27 2015, 6:50 PM
epriestley edited edge metadata.
  • Rebase.
This revision was automatically updated to reflect the committed changes.