Page MenuHomePhabricator

Show the oldest non-failing revision land operation, or the newest failure
ClosedPublic

Authored by epriestley on Oct 25 2015, 11:23 PM.
Tags
None
Referenced Files
F15388633: D14338.id34623.diff
Sat, Mar 15, 4:09 AM
F15381040: D14338.id34624.diff
Fri, Mar 14, 5:35 AM
F15305786: D14338.id34624.diff
Thu, Mar 6, 3:17 AM
Unknown Object (File)
Feb 14 2025, 3:47 AM
Unknown Object (File)
Feb 8 2025, 11:36 PM
Unknown Object (File)
Jan 28 2025, 3:50 AM
Unknown Object (File)
Jan 28 2025, 3:50 AM
Unknown Object (File)
Jan 28 2025, 3:50 AM
Subscribers
None

Details

Summary

Ref T182.

  • We just show the oldest operation right now, but we usually care about the oldest non-failure.
  • Only query for actual land operations when rendering the revision operations dialog (maybe eventually we'll show more stuff?).
  • For now, prevent multiple lands / repeated lands or queueing up lands while other lands are happening.
Test Plan

Landed a revision. Tried to land it more / again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Show the oldest non-failing revision land operation, or the newest failure.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.