Page MenuHomePhabricator

Show the oldest non-failing revision land operation, or the newest failure
ClosedPublic

Authored by epriestley on Oct 25 2015, 11:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 10, 11:31 PM
Unknown Object (File)
Apr 20 2026, 9:52 AM
Unknown Object (File)
Mar 3 2026, 9:06 PM
Unknown Object (File)
Jan 10 2026, 7:53 PM
Unknown Object (File)
Dec 23 2025, 9:12 PM
Unknown Object (File)
Dec 22 2025, 5:52 PM
Unknown Object (File)
Nov 26 2025, 3:12 PM
Unknown Object (File)
Nov 26 2025, 1:41 PM
Subscribers
None

Details

Summary

Ref T182.

  • We just show the oldest operation right now, but we usually care about the oldest non-failure.
  • Only query for actual land operations when rendering the revision operations dialog (maybe eventually we'll show more stuff?).
  • For now, prevent multiple lands / repeated lands or queueing up lands while other lands are happening.
Test Plan

Landed a revision. Tried to land it more / again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Show the oldest non-failing revision land operation, or the newest failure.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.