Differential D14326

Disable "Send Message" profile action if viewer is logged out
ClosedPublic
Actions

Authored by epriestley on Oct 24 2015, 1:41 PM.

Details

Reviewers

chad

Maniphest Tasks

T9598: "Send message" is not greyed out for logged-out users

Commits

Restricted Diffusion Commit
rP32dc62955a3c: Disable "Send Message" profile action if viewer is logged out

Summary

Fixes T9598.

Test Plan

Used "Send Message" as a logged-in user.
Used "Send Message" as a logged-out user. The action was disabled and clicking it popped up a login dialog.

Diff Detail

Repository

rP Phabricator

Branch

message1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8391
Build 9637: Run Core Tests
Build 9636: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34579.Oct 24 2015, 1:41 PM

epriestley retitled this revision from to Disable "Send Message" profile action if viewer is logged out.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9598: "Send message" is not greyed out for logged-out users.

chad accepted this revision.Oct 24 2015, 3:04 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 24 2015, 3:04 PM

Closed by commit rP32dc62955a3c: Disable "Send Message" profile action if viewer is logged out (authored by epriestley, committed by epriestley). · Explain WhyOct 24 2015, 3:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileController.php

3 lines

Diff 34579

View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Disable "Send Message" profile action if viewer is logged outClosedPublicActions