Page MenuHomePhabricator

Allow Script-and-Regex linter to have optional/empty capturing patterns for char/line
ClosedPublic

Authored by epriestley on Oct 19 2015, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 26 2024, 2:58 AM
Unknown Object (File)
Jan 2 2024, 8:43 AM
Unknown Object (File)
Dec 31 2023, 9:02 AM
Unknown Object (File)
Dec 27 2023, 7:14 AM
Unknown Object (File)
Dec 27 2023, 7:14 AM
Unknown Object (File)
Dec 26 2023, 6:52 PM
Unknown Object (File)
Dec 23 2023, 1:48 AM
Unknown Object (File)
Dec 21 2023, 2:26 PM

Details

Summary

See discussion in D13737. If you're using this linter to match messages which sometimes have a character, you can get "" (empty string) matches when the expression doesn't match. We'll complain about these later.

Instead, cast the matches the expected types.

Test Plan

@csilvers confirmed fix, see D13737.

Diff Detail

Repository
rARC Arcanist
Branch
srx
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8348
Build 9578: Run Core Tests
Build 9577: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow Script-and-Regex linter to have optional/empty capturing patterns for char/line.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a subscriber: csilvers.
csilvers added a reviewer: csilvers.

ship it!!!!111!1!1

This revision is now accepted and ready to land.Oct 19 2015, 9:32 PM
This revision was automatically updated to reflect the committed changes.