Page MenuHomePhabricator

Allow Script-and-Regex linter to have optional/empty capturing patterns for char/line
ClosedPublic

Authored by epriestley on Oct 19 2015, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 3:46 AM
Unknown Object (File)
Sun, Feb 9, 4:29 AM
Unknown Object (File)
Sat, Feb 8, 11:34 PM
Unknown Object (File)
Tue, Jan 28, 4:24 PM
Unknown Object (File)
Sat, Jan 25, 12:29 AM
Unknown Object (File)
Fri, Jan 24, 9:27 AM
Unknown Object (File)
Tue, Jan 21, 1:02 PM
Unknown Object (File)
Tue, Jan 21, 9:27 AM

Details

Summary

See discussion in D13737. If you're using this linter to match messages which sometimes have a character, you can get "" (empty string) matches when the expression doesn't match. We'll complain about these later.

Instead, cast the matches the expected types.

Test Plan

@csilvers confirmed fix, see D13737.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow Script-and-Regex linter to have optional/empty capturing patterns for char/line.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a subscriber: csilvers.
csilvers added a reviewer: csilvers.

ship it!!!!111!1!1

This revision is now accepted and ready to land.Oct 19 2015, 9:32 PM
This revision was automatically updated to reflect the committed changes.