Page MenuHomePhabricator

Allow Script-and-Regex linter to have optional/empty capturing patterns for char/line
ClosedPublic

Authored by epriestley on Oct 19 2015, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 3:50 PM
Unknown Object (File)
Mon, Apr 8, 12:05 PM
Unknown Object (File)
Mon, Apr 8, 11:00 AM
Unknown Object (File)
Mon, Apr 8, 11:00 AM
Unknown Object (File)
Mon, Apr 8, 10:43 AM
Unknown Object (File)
Mon, Apr 8, 8:51 AM
Unknown Object (File)
Mon, Apr 8, 8:38 AM
Unknown Object (File)
Wed, Apr 3, 10:14 PM

Details

Summary

See discussion in D13737. If you're using this linter to match messages which sometimes have a character, you can get "" (empty string) matches when the expression doesn't match. We'll complain about these later.

Instead, cast the matches the expected types.

Test Plan

@csilvers confirmed fix, see D13737.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow Script-and-Regex linter to have optional/empty capturing patterns for char/line.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a subscriber: csilvers.
csilvers added a reviewer: csilvers.

ship it!!!!111!1!1

This revision is now accepted and ready to land.Oct 19 2015, 9:32 PM
This revision was automatically updated to reflect the committed changes.