Initialize `$assign_phid` properly in the "!assign" email action
ClosedPublic
Actions

Authored by epriestley on Oct 16 2015, 12:48 PM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rPcdd5e3f7ddac: Initialize `$assign_phid` properly in the "!assign" email action

Summary

If you !assign cahd when you meant to !assign chad, we'll hit an "Undefined variable: assign_phid" a little further down.

Test Plan

Eyeballed it. See IRC.

Diff Detail

Repository

rP Phabricator

Branch

assign1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8305
Build 9522: Run Core Tests
Build 9521: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34493.Oct 16 2015, 12:48 PM

epriestley retitled this revision from to Initialize `$assign_phid` properly in the "!assign" email action.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added inline comments.Oct 16 2015, 12:49 PM

src/applications/maniphest/command/ManiphestAssignEmailCommand.php
51	Specifically, this is where the issue occurs.

chad accepted this revision.Oct 16 2015, 1:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 16 2015, 1:38 PM

Closed by commit rPcdd5e3f7ddac: Initialize `$assign_phid` properly in the "!assign" email action (authored by epriestley, committed by epriestley). · Explain WhyOct 16 2015, 1:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

command/

ManiphestAssignEmailCommand.php

1 line

Diff 34493

View Options

src/applications/maniphest/command/ManiphestAssignEmailCommand.php

Initialize `$assign_phid` properly in the "!assign" email actionClosedPublicActions