Paths

Table of Contentst

Initialize `$assign_phid` properly in the "!assign" email action
ClosedPublic
Actions

Authored by epriestley on Oct 16 2015, 12:48 PM.

Tags

None

Referenced Files

	F18864035: D14291.id34494.diff
	Mon, Nov 3, 2:18 AM

	F18856770: D14291.id34493.diff
	Sat, Nov 1, 11:26 AM

	F18840238: D14291.diff
	Mon, Oct 27, 10:41 PM

	F18830442: D14291.id.diff
	Sat, Oct 25, 6:47 AM

	F18826890: D14291.diff
	Fri, Oct 24, 6:17 AM

	F18810023: D14291.id.diff
	Sun, Oct 19, 6:57 PM

	F18809971: D14291.diff
	Sun, Oct 19, 6:27 PM

	F18807784: D14291.id34494.diff
	Sun, Oct 19, 3:27 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rPcdd5e3f7ddac: Initialize `$assign_phid` properly in the "!assign" email action

Summary

If you !assign cahd when you meant to !assign chad, we'll hit an "Undefined variable: assign_phid" a little further down.

Test Plan

Eyeballed it. See IRC.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34493.Oct 16 2015, 12:48 PM

epriestley retitled this revision from to Initialize `$assign_phid` properly in the "!assign" email action.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added inline comments.Oct 16 2015, 12:49 PM

src/applications/maniphest/command/ManiphestAssignEmailCommand.php
51	Specifically, this is where the issue occurs.

chad accepted this revision.Oct 16 2015, 1:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 16 2015, 1:38 PM

Closed by commit rPcdd5e3f7ddac: Initialize `$assign_phid` properly in the "!assign" email action (authored by epriestley, committed by epriestley). · Explain WhyOct 16 2015, 1:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

command/

ManiphestAssignEmailCommand.php

1 line

Diff 34494

View Options

src/applications/maniphest/command/ManiphestAssignEmailCommand.php

Initialize `$assign_phid` properly in the "!assign" email actionClosedPublicActions