Differential D14287

Remove "_-_" -> "-" slug behavior
ClosedPublic
Actions

Authored by epriestley on Oct 15 2015, 10:32 AM.

Details

Reviewers

chad

Maniphest Tasks

T9573: Documents with " - " space hyphen space are inaccessible

Commits

Restricted Diffusion Commit
rP034ff3c8708f: Remove "_-_" -> "-" slug behavior

Summary

Fixes T9573. This incorrectly affected Phriction. I could restore it for only projects, but you didn't like the rule very much anyway and I don't feel strongly about it.

Test Plan

Unit tests.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34485.Oct 15 2015, 10:32 AM

epriestley retitled this revision from to Remove "_-_" -> "-" slug behavior.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9573: Documents with " - " space hyphen space are inaccessible .

chad accepted this revision.Oct 15 2015, 1:41 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 15 2015, 1:41 PM

Closed by commit rP034ff3c8708f: Remove "_-_" -> "-" slug behavior (authored by epriestley, committed by epriestley). · Explain WhyOct 15 2015, 2:04 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T9842: Can't navigate to phriction page with apostrophe in title.Nov 24 2015, 4:55 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

util/

PhabricatorSlug.php

7 lines

__tests__/

PhabricatorSlugTestCase.php

4 lines

Diff 34487

View Options

src/infrastructure/util/PhabricatorSlug.php

View Options

src/infrastructure/util/tests/PhabricatorSlugTestCase.php

Remove "_-_" -> "-" slug behaviorClosedPublicActions