Page MenuHomePhabricator

If the stars align, make "Land Revision" kind of work
ClosedPublic

Authored by epriestley on Oct 13 2015, 10:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 8:30 AM
Unknown Object (File)
Sun, Apr 21, 9:50 PM
Unknown Object (File)
Fri, Apr 19, 3:45 PM
Unknown Object (File)
Sat, Apr 13, 3:01 PM
Unknown Object (File)
Mon, Apr 8, 8:12 AM
Unknown Object (File)
Apr 1 2024, 9:48 AM
Unknown Object (File)
Mar 31 2024, 7:41 PM
Unknown Object (File)
Mar 13 2024, 10:02 PM
Subscribers
None

Details

Summary

Ref T182. If 35 other things are configured completely correctly, make it remotely possible that this button may do something approximating the thing that the user wanted.

This primarily fleshes out the idea that "operations" (like landing, merging or cherry-picking) can have some beahavior, and when we run an operation we do whatever that behavior is instead of just running git show.

Broadly, this isn't too terrible because Drydock seems like it actually works properly for the most part (???!?!).

Test Plan

Screen Shot 2015-10-13 at 3.23.06 PM.png (242×467 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Branch
merge4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/storage/DifferentialDiff.php:480XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 8264
Build 9464: Run Core Tests
Build 9463: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to If the stars align, make "Land Revision" kind of work.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2015, 10:43 PM
This revision was automatically updated to reflect the committed changes.