Page MenuHomePhabricator

If the stars align, make "Land Revision" kind of work
ClosedPublic

Authored by epriestley on Oct 13 2015, 10:36 PM.
Tags
None
Referenced Files
F15530552: D14270.id34448.diff
Wed, Apr 23, 5:25 AM
F15527975: D14270.id34451.diff
Tue, Apr 22, 8:04 AM
F15521634: D14270.diff
Sun, Apr 20, 3:35 PM
F15512957: D14270.id.diff
Thu, Apr 17, 3:10 PM
F15509897: D14270.diff
Wed, Apr 16, 5:13 PM
F15457357: D14270.diff
Mar 30 2025, 3:53 PM
F15451970: D14270.id34448.diff
Mar 29 2025, 12:55 AM
F15385603: D14270.diff
Mar 14 2025, 10:57 PM
Subscribers
None

Details

Summary

Ref T182. If 35 other things are configured completely correctly, make it remotely possible that this button may do something approximating the thing that the user wanted.

This primarily fleshes out the idea that "operations" (like landing, merging or cherry-picking) can have some beahavior, and when we run an operation we do whatever that behavior is instead of just running git show.

Broadly, this isn't too terrible because Drydock seems like it actually works properly for the most part (???!?!).

Test Plan

Screen Shot 2015-10-13 at 3.23.06 PM.png (242×467 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to If the stars align, make "Land Revision" kind of work.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2015, 10:43 PM
This revision was automatically updated to reflect the committed changes.