Paths

Table of Contentst

Differential D14245

Added support for settings the LDAP email attribute
Needs ReviewPublic
Actions

Authored by robloxianmany on Oct 7 2015, 7:19 PM.

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Summary

Added the ability to set a different LDAP email attribute, one other than mail.

Not all LDAP servers use mail as their email attribute. My local LDAP server uses, for example, userPrincipalName.

Depends on D14244

Test Plan

Depends on D14244

Configure Phabricator to use an LDAP server for authentication, one configured with no mail attribute.

Set the email attribute in the LDAP config.

Perform an LDAP Import.

You should be able to import the LDAP account with the email attribute you configured. In the past, it would have failed due to no email.

Diff Detail

Repository

rP Phabricator

Branch

ldapemail

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8206
Build 9383: arc lint + arc unit

Event Timeline

robloxianmany updated this revision to Diff 34394.Oct 7 2015, 7:19 PM

robloxianmany retitled this revision from to Added support for settings the LDAP email attribute.

robloxianmany updated this object.

robloxianmany edited the test plan for this revision. (Show Details)

robloxianmany set the repository for this revision to rP Phabricator.

robloxianmany added a parent revision: D14244: Added the ability to configure the email attribute for LDAP.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 7 2015, 7:19 PM

Herald added a subscriber: epriestley. · View Herald Transcript

• Myzael added a subscriber: • Myzael.Oct 8 2015, 9:20 AM

• Myzael removed a subscriber: • Myzael.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

provider/

PhabricatorLDAPAuthProvider.php

9 lines

Diff 34394

View Options

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

Added support for settings the LDAP email attributeNeeds ReviewPublicActions