Paths

Table of Contentst

Allow PhabricatorWorker->queueTask() to take full $options
ClosedPublic
Actions

Authored by epriestley on Oct 5 2015, 3:29 PM.

Details

Reviewers

hach-que
chad

Maniphest Tasks

T9252: Unprototype Drydock (v1)

Commits

Restricted Diffusion Commit
rPde2bbfef7d14: Allow PhabricatorWorker->queueTask() to take full $options

Summary

Ref T9252. Currently, queueTask() accepts $priority as its third argument. Allow it to take a full range of $options instead. This API just never got updated after we expanded avialable options.

Arguably this whole API should be some kind of "TaskQueueRequest" object but I'll leave that for another day.

Test Plan

Grepped for queueTask() and verified no other callsites are affected by this API change.
Ran some daemons.
See also next diff.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34373.Oct 5 2015, 3:29 PM

epriestley retitled this revision from to Allow PhabricatorWorker->queueTask() to take full $options.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, hach-que.

epriestley added a task: T9252: Unprototype Drydock (v1).

hach-que accepted this revision.Oct 5 2015, 3:36 PM

hach-que edited edge metadata.

This revision is now accepted and ready to land.Oct 5 2015, 3:36 PM

___________ < amazing > ----------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||

Closed by commit rPde2bbfef7d14: Allow PhabricatorWorker->queueTask() to take full $options (authored by epriestley, committed by epriestley). · Explain WhyOct 5 2015, 4:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

workers/

PhabricatorWorker.php

12 lines

storage/

PhabricatorWorkerActiveTask.php

15 lines

Diff 34375

View Options

src/infrastructure/daemon/workers/PhabricatorWorker.php