Page MenuHomePhabricator
Differential D14235

Allow PhabricatorWorker->queueTask() to take full $options
ClosedPublic
Actions

Authored by epriestley on Oct 5 2015, 3:29 PM.
Tags
None
Referenced Files
F14039962: D14235.id34375.diff
Mon, Nov 11, 6:53 AM
F14038904: D14235.diff
Mon, Nov 11, 2:41 AM
F14038666: D14235.diff
Mon, Nov 11, 1:08 AM
F14023462: D14235.diff
Thu, Nov 7, 2:10 AM
F14019344: D14235.id34375.diff
Tue, Nov 5, 9:57 PM
F14019343: D14235.id34373.diff
Tue, Nov 5, 9:57 PM
F14019342: D14235.id.diff
Tue, Nov 5, 9:57 PM
F14016541: D14235.diff
Mon, Nov 4, 10:02 AM
View All Files
Subscribers
None

Details

Reviewers
hach-que
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rPde2bbfef7d14: Allow PhabricatorWorker->queueTask() to take full $options
Summary

Ref T9252. Currently, queueTask() accepts $priority as its third argument. Allow it to take a full range of $options instead. This API just never got updated after we expanded avialable options.

Arguably this whole API should be some kind of "TaskQueueRequest" object but I'll leave that for another day.

Test Plan
  • Grepped for queueTask() and verified no other callsites are affected by this API change.
  • Ran some daemons.
  • See also next diff.

Diff Detail

Repository
rP Phabricator
Branch
dock1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8184
Build 9354: Run Core Tests
Build 9353: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34373.Oct 5 2015, 3:29 PM
epriestley retitled this revision from to Allow PhabricatorWorker->queueTask() to take full $options.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
epriestley added a task: T9252: Unprototype Drydock (v1).
hach-que accepted this revision.Oct 5 2015, 3:36 PM
hach-que edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2015, 3:36 PM
chad accepted this revision.Oct 5 2015, 4:07 PM
chad edited edge metadata.
___________ < amazing > ----------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||
Closed by commit rPde2bbfef7d14: Allow PhabricatorWorker->queueTask() to take full $options (authored by epriestley, committed by epriestley). · Explain WhyOct 5 2015, 4:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
daemon/
workers/
12 lines
storage/
15 lines

Diff 34373

View Options

src/infrastructure/daemon/workers/PhabricatorWorker.php

Loading...
View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php

Loading...
Phabricator · Built by Phacility