Page MenuHomePhabricator

Allow an arc test to execute without a git author configured
ClosedPublic

Authored by epriestley on Oct 4 2015, 3:22 PM.
Tags
None
Referenced Files
F14082428: D14232.diff
Fri, Nov 22, 11:49 PM
F14078168: D14232.id34367.diff
Fri, Nov 22, 2:32 AM
Unknown Object (File)
Wed, Nov 20, 12:34 PM
Unknown Object (File)
Wed, Nov 20, 12:34 PM
Unknown Object (File)
Wed, Nov 20, 12:34 PM
Unknown Object (File)
Wed, Nov 20, 12:34 PM
Unknown Object (File)
Mon, Nov 18, 11:34 PM
Unknown Object (File)
Fri, Nov 15, 9:38 AM
Subscribers
None

Details

Summary

On sbuild, we currently get a failure on this test. Use an explicit --author so we can run the test even if user.email and user.name are not set in global Git config.

   FAIL  ArcanistBundleTestCase::testGitRepository
15	EXCEPTION (CommandException): Command failed with error #128!
16	COMMAND
17	git commit -m 'Mark koan2 +x and edit it.'
18	
19	STDOUT
20	(empty)
21	
22	STDERR
23	
24	*** Please tell me who you are.
25	
26	Run
27	
28	  git config --global user.email "you@example.com"
29	  git config --global user.name "Your Name"
30	
31	to set your account's default identity.
32	Omit --global to set the identity only in this repository.
33	
34	fatal: empty ident name (for <builder@sbuild001.phacility.net>) not allowed
Test Plan

Ran arc unit --everything. Will verify in production.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow an arc test to execute without a git author configured.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 4 2015, 3:30 PM
This revision was automatically updated to reflect the committed changes.

Unfortunately, this didn't work at all. I'll figure out what's up...