Differential D14231
Allow Filesystem::walkToRoot() to operate on fictional paths Authored by epriestley on Oct 4 2015, 2:17 PM. Tags None Referenced Files
Subscribers None
Details This is part of fixing a unit test in arc, but generally seems like a reasonable/desirable behavior. If you have a path like /x/y/z, where the path is fictional and none of the components actually exist:
The old behavior seems reasonable to me. Added a unit test, ran unit tests. See next revision (test in arc) for additional context.
Diff Detail
Event TimelineComment Actions This completely fixes the test in arc so there's actually no second diff, but here was the failure: FAIL PhpunitTestEngineTestCase::testSearchLocations Assertion failed, expected values to be equal (at PhpunitTestEngineTestCase.php:39). Expected vs Actual Output Diff --- Old Value +++ New Value @@ -1,29 +1,21 @@ Array ( [0] => /path/to/some/file/ - [1] => /path/to/some/file/tests/ - [2] => /path/to/some/file/Tests/ - [3] => /path/to/some/tests/ - [4] => /path/to/some/Tests/ - [5] => /path/to/tests/ - [6] => /path/to/Tests/ - [7] => /path/tests/ - [8] => /path/Tests/ - [9] => /tests/ - [10] => /Tests/ - [11] => /path/to/tests/file/ - [12] => /path/to/Tests/file/ - [13] => /path/tests/some/file/ - [14] => /path/Tests/some/file/ - [15] => /tests/to/some/file/ - [16] => /Tests/to/some/file/ - [17] => /path/to/some/tests/file/ - [18] => /path/to/some/Tests/file/ - [19] => /path/to/tests/some/file/ - [20] => /path/to/Tests/some/file/ - [21] => /path/tests/to/some/file/ - [22] => /path/Tests/to/some/file/ - [23] => /tests/path/to/some/file/ - [24] => /Tests/path/to/some/file/ + [1] => /path/to/some/tests/ + [2] => /path/to/some/Tests/ + [3] => /path/to/tests/file/ + [4] => /path/to/Tests/file/ + [5] => /path/tests/some/file/ + [6] => /path/Tests/some/file/ + [7] => /tests/to/some/file/ + [8] => /Tests/to/some/file/ + [9] => /path/to/some/tests/file/ + [10] => /path/to/some/Tests/file/ + [11] => /path/to/tests/some/file/ + [12] => /path/to/Tests/some/file/ + [13] => /path/tests/to/some/file/ + [14] => /path/Tests/to/some/file/ + [15] => /tests/path/to/some/file/ + [16] => /Tests/path/to/some/file/ ) All paths except /tests/ and /Tests/ were failing because Filesystem::walkToRoot() no longer walked them (since they do not exist). The /tests/ and /Tests/ paths were failing because Filesystem::walkToRoot() no longer walked "/". |