Page MenuHomePhabricator
Differential D14224

Fix WorkingCopy step to read correct commit variables
ClosedPublic
Actions

Authored by epriestley on Oct 2 2015, 1:36 PM.
Tags
None
Referenced Files
F15547120: D14224.diff
Sat, Apr 26, 6:17 PM
F15540343: D14224.id.diff
Fri, Apr 25, 7:12 AM
F15534462: D14224.diff
Thu, Apr 24, 12:26 AM
F15487128: D14224.id34348.diff
Thu, Apr 10, 11:29 AM
F15473760: D14224.diff
Sun, Apr 6, 1:38 AM
F15473638: D14224.id34347.diff
Sun, Apr 6, 12:25 AM
F15460845: D14224.id34348.diff
Tue, Apr 1, 2:51 AM
F15453427: D14224.id34347.diff
Sat, Mar 29, 11:42 AM
View All Files
Subscribers
None

Details

Reviewers
hach-que
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rPbb4667cb8490: Fix WorkingCopy step to read correct commit variables
Summary

Ref T9252. This variable was always wrong but we fell back to just resetting to HEAD before. Use the correct variable name.

Test Plan

Verified variable name.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34347.Oct 2 2015, 1:36 PM
epriestley retitled this revision from to Fix WorkingCopy step to read correct commit variables.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
epriestley added a task: T9252: Unprototype Drydock (v1).
hach-que accepted this revision.Oct 2 2015, 1:36 PM
hach-que edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2015, 1:36 PM
Closed by commit rPbb4667cb8490: Fix WorkingCopy step to read correct commit variables (authored by epriestley, committed by epriestley). · Explain WhyOct 2 2015, 1:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
step/
2 lines

Diff 34348

View Options

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php

Loading...
Phabricator · Built by Phacility