Fix WorkingCopy step to read correct commit variables
ClosedPublic
Actions

Authored by epriestley on Oct 2 2015, 1:36 PM.

Details

Reviewers

hach-que
chad

Maniphest Tasks

T9252: Unprototype Drydock (v1)

Commits

Restricted Diffusion Commit
rPbb4667cb8490: Fix WorkingCopy step to read correct commit variables

Summary

Ref T9252. This variable was always wrong but we fell back to just resetting to HEAD before. Use the correct variable name.

Test Plan

Verified variable name.

Diff Detail

Repository

rP Phabricator

Branch

commitvar

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8155
Build 9316: Run Core Tests
Build 9315: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34347.Oct 2 2015, 1:36 PM

epriestley retitled this revision from to Fix WorkingCopy step to read correct commit variables.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, hach-que.

epriestley added a task: T9252: Unprototype Drydock (v1).

hach-que accepted this revision.Oct 2 2015, 1:36 PM

hach-que edited edge metadata.

This revision is now accepted and ready to land.Oct 2 2015, 1:36 PM

Closed by commit rPbb4667cb8490: Fix WorkingCopy step to read correct commit variables (authored by epriestley, committed by epriestley). · Explain WhyOct 2 2015, 1:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterLeaseWorkingCopyBuildStepImplementation.php

2 lines

Diff 34347

View Options

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php

Fix WorkingCopy step to read correct commit variablesClosedPublicActions