Page MenuHomePhabricator

Remove names from Drydock resources
ClosedPublic

Authored by epriestley on Oct 1 2015, 1:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 7:28 PM
Unknown Object (File)
Wed, Dec 4, 11:58 AM
Unknown Object (File)
Wed, Dec 4, 6:21 AM
Unknown Object (File)
Thu, Nov 28, 7:53 AM
Unknown Object (File)
Wed, Nov 27, 11:01 AM
Unknown Object (File)
Sat, Nov 23, 8:37 AM
Unknown Object (File)
Wed, Nov 20, 12:31 PM
Unknown Object (File)
Wed, Nov 20, 12:31 PM
Subscribers
None

Details

Reviewers
hach-que
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rPd4a0b1c8709b: Remove names from Drydock resources
Summary

Ref T9252. Long ago you sometimes manually created resources, so they had human-enterable names. However, users never make resources manually any more, so this field isn't really useful any more.

In particular, it means we write a lot of untranslatable strings like "Working Copy" to the database in the default locale. Instead, do the call at runtime so resource names are translatable.

Also clean up a few minor things I hit while kicking the tires here.

It's possible we might eventually want to introduce a human-choosable label so you can rename your favorite resources and this would just be a default name. I don't really have much of a use case for that yet, though, and I'm not sure there will ever be one.

Test Plan
  • Restarted a Harbormaster build, got a clean build.
  • Released all leases/resources, restarted build, got a clean build with proper resource names.

Diff Detail

Repository
rP Phabricator
Branch
dd14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8122
Build 9268: [Placeholder Plan] Wait for 30 Seconds
Build 9267: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Remove names from Drydock resources.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
hach-que edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2015, 1:36 PM
chad edited edge metadata.
This revision was automatically updated to reflect the committed changes.