Page MenuHomePhabricator

Give Drydock leases a resourcePHID instead of a resourceID
ClosedPublic

Authored by epriestley on Sep 24 2015, 3:28 AM.
Tags
None
Referenced Files
F14032877: D14151.id.diff
Sat, Nov 9, 4:05 PM
F14032743: D14151.id.diff
Sat, Nov 9, 3:30 PM
F13967696: D14151.id34196.diff
Oct 16 2024, 3:20 PM
F13956895: D14151.id34193.diff
Oct 14 2024, 7:30 AM
F13956894: D14151.id.diff
Oct 14 2024, 7:29 AM
F13956795: D14151.id34196.diff
Oct 14 2024, 7:08 AM
Unknown Object (File)
Oct 7 2024, 2:17 AM
Unknown Object (File)
Sep 26 2024, 6:45 PM
Subscribers
None

Details

Summary

Ref T9252. Leases currently have a resourceID, but this is a bit nonstandard and generally less flexible than giving them a resourcePHID.

In particular, a resourcePHID is easier to use when rendering interfaces, since you can get handles out of a PHID.

Add a PHID column, copy over all the PHIDs that correspond to existing IDs, then drop the ID column.

Test Plan
  • Browsed web UIs.
  • Inspected database during/after migration.
  • Grepped for resourceID.
  • Allocated a new lease with bin/drydock lease.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give Drydock leases a resourcePHID instead of a resourceID.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Sep 24 2015, 4:44 AM
This revision was automatically updated to reflect the committed changes.